From 7fd982f948317af489ef9d886d51013518bbefb3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20K=C3=A4ufl?= Date: Sat, 13 May 2017 16:29:18 +0200 Subject: [PATCH] [Dockerfiles] Do not persist DEBIAN_FRONTEND=noninteractive in images According to https://github.com/moby/moby/issues/4032#issuecomment-163689851 (and some other comments in the issue) it's not recommended to set `DEBIAN_FRONTEND` via `ENV` in a Dockerfile. `ARG` has the same effect at build time but does not change `DEBIAN_FRONTEND` in the final image, so I switched to it. It should also work to remove it completely. --- data/Dockerfiles/clamav/Dockerfile | 3 ++- data/Dockerfiles/dovecot/Dockerfile | 2 +- data/Dockerfiles/php-fpm/Dockerfile | 2 +- data/Dockerfiles/postfix/Dockerfile | 2 +- data/Dockerfiles/rmilter/Dockerfile | 2 +- data/Dockerfiles/rspamd/Dockerfile | 2 +- data/Dockerfiles/sogo/Dockerfile | 2 +- 7 files changed, 8 insertions(+), 7 deletions(-) diff --git a/data/Dockerfiles/clamav/Dockerfile b/data/Dockerfiles/clamav/Dockerfile index ce37fe25..a2551677 100755 --- a/data/Dockerfiles/clamav/Dockerfile +++ b/data/Dockerfiles/clamav/Dockerfile @@ -3,12 +3,13 @@ LABEL maintainer "https://m-ko.de Markus Kosmal " # Debian Base to use ENV DEBIAN_VERSION stretch +ARG DEBIAN_FRONTEND=noninteractive # initial install of av daemon RUN echo "deb http://http.debian.net/debian/ $DEBIAN_VERSION main contrib non-free" > /etc/apt/sources.list && \ echo "deb http://http.debian.net/debian/ $DEBIAN_VERSION-updates main contrib non-free" >> /etc/apt/sources.list && \ echo "deb http://security.debian.org/ $DEBIAN_VERSION/updates main contrib non-free" >> /etc/apt/sources.list && \ - apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y -qq --no-install-recommends \ + apt-get update && apt-get install -y -qq --no-install-recommends \ clamav-daemon \ clamav-freshclam \ libclamunrar7 \ diff --git a/data/Dockerfiles/dovecot/Dockerfile b/data/Dockerfiles/dovecot/Dockerfile index 708ff8bd..1aafecd0 100644 --- a/data/Dockerfiles/dovecot/Dockerfile +++ b/data/Dockerfiles/dovecot/Dockerfile @@ -2,7 +2,7 @@ FROM debian:stretch-slim #ubuntu:xenial LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive ENV LC_ALL C ENV DOVECOT_VERSION 2.2.29.1 ENV PIGEONHOLE_VERSION 0.4.18 diff --git a/data/Dockerfiles/php-fpm/Dockerfile b/data/Dockerfiles/php-fpm/Dockerfile index 9d7e5c0b..0d65040f 100644 --- a/data/Dockerfiles/php-fpm/Dockerfile +++ b/data/Dockerfiles/php-fpm/Dockerfile @@ -1,7 +1,7 @@ FROM php:7.1-fpm LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive RUN apt-get update && apt-get install -y \ g++ \ diff --git a/data/Dockerfiles/postfix/Dockerfile b/data/Dockerfiles/postfix/Dockerfile index ad7ca5f3..e74e8725 100644 --- a/data/Dockerfiles/postfix/Dockerfile +++ b/data/Dockerfiles/postfix/Dockerfile @@ -1,7 +1,7 @@ FROM debian:stretch-slim LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive ENV LC_ALL C RUN dpkg-divert --local --rename --add /sbin/initctl \ diff --git a/data/Dockerfiles/rmilter/Dockerfile b/data/Dockerfiles/rmilter/Dockerfile index 405dc90e..abe286f6 100644 --- a/data/Dockerfiles/rmilter/Dockerfile +++ b/data/Dockerfiles/rmilter/Dockerfile @@ -1,7 +1,7 @@ FROM debian:jessie-slim LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive ENV LC_ALL C RUN apt-key adv --fetch-keys http://rspamd.com/apt-stable/gpg.key \ diff --git a/data/Dockerfiles/rspamd/Dockerfile b/data/Dockerfiles/rspamd/Dockerfile index 61386754..cb097a66 100644 --- a/data/Dockerfiles/rspamd/Dockerfile +++ b/data/Dockerfiles/rspamd/Dockerfile @@ -1,7 +1,7 @@ FROM debian:jessie-slim LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive ENV LC_ALL C RUN apt-key adv --fetch-keys http://rspamd.com/apt-stable/gpg.key \ diff --git a/data/Dockerfiles/sogo/Dockerfile b/data/Dockerfiles/sogo/Dockerfile index 054f5a77..475468b1 100644 --- a/data/Dockerfiles/sogo/Dockerfile +++ b/data/Dockerfiles/sogo/Dockerfile @@ -1,7 +1,7 @@ FROM debian:jessie-slim LABEL maintainer "Andre Peters " -ENV DEBIAN_FRONTEND noninteractive +ARG DEBIAN_FRONTEND=noninteractive ENV LC_ALL C ENV GOSU_VERSION 1.9